This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Added support for configuring AWS S3 CNAME. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, trying to test it out a bit. I like the idea as I could see myself using it in the future too. The only thing I am curious about is if there is a way to make the I made an issue on the AWS PHP SDK to ask if it is still possible. |
dmyers
force-pushed
the
master
branch
3 times, most recently
from
fe8c8a0 to
2c4d3b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I have came up with another feature request! :)
This enables us to use a custom previously-configured CNAME (Amazon CloudFront CDN) to be used when building URLs, thus serving the files with a custom domain.
Hope you like it! 👍