New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add now function to Timestamp #56

Merged

dmurvihill merged 2 commits into dmurvihill:master from nui-os:master

Mar 2, 2020

tobiaseisenschenk commented Feb 27, 2020

We are using the now constructor on Timestamp in our project so I figured I'd add it here as well. Please let me know if I forgot anything.


          feat: add now function to Timestamp

52393a3

dmurvihill reviewed

View reviewed changes

Owner

dmurvihill left a comment

Thanks! Requesting one change to the test, and could you also add an entry to the change log?

test/unit/timestamp.js Show resolved Hide resolved


          test: fake timers with sinon

689add6

dmurvihill merged commit d1c7634 into dmurvihill:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet