Skip to content

aiohttp 3.10+ compatibility #240

Open
@gepbird

Description

Before opening an issue make sure that there are no duplicates and that you are
on the latest version.
Describe the bug
When using aiohttp 3.10+, I get this error when running this app: RuntimeError: no running event loop.

To Reproduce
Steps to reproduce the behavior:

  1. Update aiohttp to 3.11.11
  2. Run iSponsorBlockTV setup-cli
  3. See error

Expected behavior
No error

Screenshots

 ❯ iSponsorBlockTV setup-cli
Could not load config file
Blank config file created
Welcome to the iSponsorBlockTV cli setup wizard
Traceback (most recent call last):
  File "/nix/store/gh6q9s7nlbz2128p6pa6aycrsqlcxmx3-iSponsorBlockTV-2.2.1/bin/.iSponsorBlockTV-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/gh6q9s7nlbz2128p6pa6aycrsqlcxmx3-iSponsorBlockTV-2.2.1/lib/python3.12/site-packages/iSponsorBlockTV/__main__.py", line 5, in main
    helpers.app_start()
  File "/nix/store/gh6q9s7nlbz2128p6pa6aycrsqlcxmx3-iSponsorBlockTV-2.2.1/lib/python3.12/site-packages/iSponsorBlockTV/helpers.py", line 218, in app_start
    cli(obj={})
  File "/nix/store/1xajkynqwbk8bdlj8d84wypqivmnkh7g-python3.12-rich-click-1.8.5/lib/python3.12/site-packages/rich_click/rich_command.py", line 367, in __call__
    return super().__call__(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/1dx2z4h3yddb2s0flwyl5l64l4g3h9lj-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/1xajkynqwbk8bdlj8d84wypqivmnkh7g-python3.12-rich-click-1.8.5/lib/python3.12/site-packages/rich_click/rich_command.py", line 152, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/nix/store/1dx2z4h3yddb2s0flwyl5l64l4g3h9lj-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/1dx2z4h3yddb2s0flwyl5l64l4g3h9lj-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/1dx2z4h3yddb2s0flwyl5l64l4g3h9lj-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/1dx2z4h3yddb2s0flwyl5l64l4g3h9lj-python3.12-click-8.1.7/lib/python3.12/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/gh6q9s7nlbz2128p6pa6aycrsqlcxmx3-iSponsorBlockTV-2.2.1/lib/python3.12/site-packages/iSponsorBlockTV/helpers.py", line 182, in setup_cli
    config_setup.main(config, ctx.obj["debug"])
  File "/nix/store/gh6q9s7nlbz2128p6pa6aycrsqlcxmx3-iSponsorBlockTV-2.2.1/lib/python3.12/site-packages/iSponsorBlockTV/config_setup.py", line 74, in main
    web_session = aiohttp.ClientSession()
                  ^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c4v4aq01pjxw5cqc5brklvjbf0qw1w5i-python3.12-aiohttp-3.11.11/lib/python3.12/site-packages/aiohttp/client.py", line 310, in __init__
    loop = loop or asyncio.get_running_loop()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: no running event loop

iSponsorBlockTV server (please complete the following information):

  • OS: NixOS 24.11 x64
  • Python version: 3.12.8

Additional context
Upstream issue: aio-libs/aiohttp#8555

Open PRs (needs manual fixing):

We notice this in nixpkgs (NixOS/nixpkgs#370525) where we try to use the latest dependencies.

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions