-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump date-fns to v3 #656
Conversation
…e for compatibility
I'm ok with duplication but we should probably bump the major version as well. Not sure for all of packages or not |
Ok. I totally agree that |
We can do that later, but what is requried right now it to ensure that the tests are running for both versions of date-fns and we have proper 100% coverage support |
Sorry, why did you remove the date-fns-v2? |
Working on the tests, I decided to revert the date-fns-v2 because those have explicit reference to the date-fns package. Furthermore, I think that keeping an old version might be overengineered if we do a major version bump on |
@dmtrKovalenko do you think we should maintain a compatibility with date-fns v2 on master ? |
Thank you for contributation, I am going to merge this right and now and make another breaking changes that I wanted to make for a long time and will release a new version today |
I try here to solve #655 and support last version of date-fns with its breaking changes.
I decided heer to keep a specific package for backwards compatibility. Not a fan of the resulting code duplication but it's a proposal.