fix: add BIP39 mnemonic validation before wallet operations #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import validateMnemonic from @scure/bip39 - Add validation in handleCreateWallet before creating new wallet - Add validation in handleRestoreFromManual before restoring wallet - Prevents cryptic errors from invalid seed phrases - Shows clear error message: 'Invalid seed phrase. Please check your 12-word recovery phrase.'
|
@Thegreenpiranha is attempting to deploy a commit to the The Daniel's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds BIP39 mnemonic validation before wallet creation and restoration to prevent cryptic errors from invalid seed phrases.
Problem
Currently, users can enter invalid mnemonics (wrong words, wrong word count, gibberish) when restoring a wallet. The app accepts these and attempts to connect, resulting in cryptic Breez SDK errors that confuse users.
Example invalid inputs that are currently accepted:
Solution
validateMnemonicfrom@scure/bip39handleCreateWallet()before creating wallethandleRestoreFromManual()before restoring walletTesting
Impact
Improves UX by catching invalid seed phrases early with clear error messages instead of cryptic SDK failures.