Repository navigation
fix(dependencies): move babel-plugin-macros to optional peer - #60
Merged
Merged
Conversation
fixes #47 In the strictest sense, this is a breaking change, but I don't think this is realistic, as someone using babel-plugin-macros only through the transitive dependencies of this package would be rare
JoshuaKGoldberg
approved these changes
Jul 18, 2023
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Collaborator
There was a problem hiding this comment.
+1, I agree this can be considered a minor version rather than major. Thanks!
Collaborator
|
Released as |
3 tasks done
3 tasks done
JoshuaKGoldberg
added a commit
that referenced
this pull request
Feb 18, 2024
## PR Checklist - [x] Addresses an existing open issue: fixes #88 - [x] That issue was marked as [`status: accepting prs`](https://github.com/dmnd/dedent/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/dmnd/dedent/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Re-applies #60 per the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #47
In the strictest sense, this is a breaking change, but I don't think this is realistic, as someone using babel-plugin-macros only through the transitive dependencies of this package would be rare