Skip to content

Commit

Permalink
Cherry pick disabling of pkg.translator.prometheus.NormalizeName FG
Browse files Browse the repository at this point in the history
Set `pkg.translator.prometheus.NormalizeName` feature gate back to Alpha state since it was enabled prematurely. Metrics coming from Prometheus receiver will not be normalized by default, specifically `_total` suffix will not be removed from metric names. To maintain the current behavior (drop the `_total` suffix), you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, note that the translation in the prometheus receiver is a subject to possible future changes.  See [issue #23208](open-telemetry/opentelemetry-collector-contrib#23208) for more details.
  • Loading branch information
dmitryax committed Jun 12, 2023
1 parent 319ae6c commit 4ab24ea
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

## Unreleased

### 🛑 Breaking changes 🛑

- (Contrib) Set `pkg.translator.prometheus.NormalizeName` feature gate back to Alpha state since it was enabled
prematurely. Metrics coming from Prometheus receiver will not be normalized by default, specifically `_total` suffix
will not be removed from metric names. To maintain the current behavior (drop the `_total` suffix), you can enable
the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, note
that the translation in the prometheus receiver is a subject to possible future changes.
([#23229](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23229))

## v0.78.1

### 🧰 Bug fixes 🧰
Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/oracledbreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusexecreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.1-0.20230612155822-9d5526cf2998
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sapmreceiver v0.79.0
Expand Down Expand Up @@ -196,7 +196,7 @@ require (
github.com/ardielle/ardielle-go v1.5.2 // indirect
github.com/armon/go-metrics v0.4.1 // indirect
github.com/armon/go-radix v1.0.0 // indirect
github.com/aws/aws-sdk-go v1.44.274 // indirect
github.com/aws/aws-sdk-go v1.44.277 // indirect
github.com/aws/aws-sdk-go-v2 v1.18.0 // indirect
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10 // indirect
github.com/aws/aws-sdk-go-v2/credentials v1.13.24 // indirect
Expand Down
4 changes: 4 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ github.com/aws/aws-sdk-go v1.38.35/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2z
github.com/aws/aws-sdk-go v1.40.45/go.mod h1:585smgzpB/KqRA+K3y/NL/oYRqQvpNJYvLm+LY1U59Q=
github.com/aws/aws-sdk-go v1.44.274 h1:vfreSv19e/9Ka9YytOzgzJasrRZfX7dnttLlbh8NKeA=
github.com/aws/aws-sdk-go v1.44.274/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
github.com/aws/aws-sdk-go v1.44.277 h1:YHmyzBPARTJ7LLYV1fxbfEbQOaUh3kh52hb7nBvX3BQ=
github.com/aws/aws-sdk-go v1.44.277/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
github.com/aws/aws-sdk-go-v2 v1.9.1/go.mod h1:cK/D0BBs0b/oWPIcX/Z/obahJK1TT7IPVjy53i/mX/4=
github.com/aws/aws-sdk-go-v2 v1.9.2/go.mod h1:cK/D0BBs0b/oWPIcX/Z/obahJK1TT7IPVjy53i/mX/4=
github.com/aws/aws-sdk-go-v2 v1.17.7/go.mod h1:uzbQtefpm44goOPmdKyAlXSNcwlRgF3ePWVW6EtJvvw=
Expand Down Expand Up @@ -1262,6 +1264,8 @@ github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusexe
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusexecreceiver v0.79.0/go.mod h1:xAXBpCVNAU8Y9AlFiQzU3JvJnDxM4otcW14FZnksa6I=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.0 h1:+mJSVctdGemxKt2O6ZaccrNEiWQ7OCRuGfD+9nUEZRg=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.0/go.mod h1:+0BrsZx0PGVAnAdHS5F1du1AbUqsEwBrg1UrQfKPdd8=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.1-0.20230612155822-9d5526cf2998 h1:soVXfvycoHWwXYCXbA/4+S9ktbEzohCshtBlagmDKPg=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.1-0.20230612155822-9d5526cf2998/go.mod h1:M4t+1NhOsJKd25EeosRjdBpy/5Qnb0RVCMoOHNrzs80=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.79.0 h1:PIOFy5/GivJuDhy97R4KnRic2BB777Vf45b3WAP+GYE=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.79.0/go.mod h1:jKSUs5RXRuYMb66RshAJXADv35+4+PMSb+/y6UVGI9U=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver v0.79.0 h1:CuZbOGP8y0FHgNHZTefTQNXIvnLwy7xGYF4a+GjQFn8=
Expand Down

0 comments on commit 4ab24ea

Please sign in to comment.