Fix loading fan mode advances after restart and wake-up#288
Open
ahamid-ha wants to merge 2 commits intodmitry-s93:mainfrom
Open
Fix loading fan mode advances after restart and wake-up#288ahamid-ha wants to merge 2 commits intodmitry-s93:mainfrom
ahamid-ha wants to merge 2 commits intodmitry-s93:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MControlCenter is first loaded, the advanced fan mode is not set correctly if enabled. This is due to a race condition between setUserMode which sets it to auto using MsiEcHelper (which is async), and loadSettings using the old putValue.
Also in my case (Raider GE67HX 12UGS) after wake-up the fans' curves are reset by the firmware, so I updated the handleWakeEvent to reload them.