Make shift mode and fan mode available with a Custom profile

[Jiogo18]

Suggestion inspired from #246

Add a "Custom" UserMode, so the user can set ShiftMode and FanMode through combo boxes or radio buttons.

This would allow having super battery + advanced or auto fan.
Yes, it also means we can have performance + silent fan, but this case can have a warning and "incompatible with... are you sure" dialog.

It would also allow using other modes such as sport if available.

Those inputs can still be changed when not in custom mode.
But as soon as the user changes shift or fan mode, user mode radio buttons are set to "Custom" (or a profile if there is a match).

Other proposals

• If the inputs are combo boxes, they can fit in the first tab. Otherwise, add a new "Advanced Profiles" tab.
• In the future, FanMode combobox could handle the custom advanced fan curves. The first entries are msi modes, the later are "Custom 1", "Custom 2"...
• Advanced fan curve could be edited whether advanced mode is enabled or not.

[mutchiko]

Right now, how advanced mode actually works isn't really clear, it seems to change between each family of laptops.

as far as i know, to activate advanced fan mode, you need to use the performance shift mode, this means C4 value in most cases, some devices use C0 in shift mode for advanced fan mode, this has the same effect as performance in power but unlocks the entire fan speed range, so it allows for above 100% speeds (usually between 120% or 150%). office devices with or without 2 fans are usually excluded from this.

in my case, i cant have super battery shift mode and be able to control the fans, GPU fan curve seems to apply in balanced shift mode but not the CPU curve. only in performance that i get control of both fans, this might be different for you so please check if you can.

in the end, i agree on the principles, the current handling of advanced fan mode should be improved.

[Jiogo18]

With my laptop, advanced mode applies both fan curves, for the three shift modes.

What I tried

In MCC:

1. set super battery
2. uncheck and check advanced mode again (always check fan mode label)
3. set both fan curves at 100%.

cat /sys/devices/platform/msi-ec/*_mode
advanced
eco

CPU and GPU fans at 5.8-6k rpm as expected.
Same with comfort and turbo
Reaching to 6000 rpm can be slow though.

Also tried: set performance + advanced in MCC,
then write eco to msi-ec/shift_mod.
CPU fan speed hasn't changed.

---

I noticed in auto, GPU fan speed follows the curve. That may be a source of confusion.
Make sure fan mode label is advanced, since MCC profiles change it to auto (#246).

[mutchiko]

i've been trying for a while now, i don't get the same results as you

File: /sys/devices/platform/msi-ec/fan_mode
advanced

File: /sys/devices/platform/msi-ec/shift_mode
eco

CPU fan curve is maxed out, yet the fan still refuses to turn on.
and this is the case for all shift modes except for high performance which writes C1 to EC.

according to my older notes and screenshots, this shouldn't be the case with the official MSI apps

inside user mode, selecting the high performance level writes C0 instead of the C1 in the regular performance mode selector.

i compared ryzen power profiles and both of C0 and C1 have the same power profiles on the CPU/GPU, i assume the difference is that C0 unlocks 150% fan speed, but i haven't tested yet.

[Jiogo18]

First though: we may have a different firmware.
Also, I have MSI Center instead of Dragon Center on Windows, It could change something somehow.

except for high performance which writes C1 to EC.

Do you mean C4?

But now, I wonder if shift_mode actually works on my laptop.
When my laptop wakes up, shift_mode is 0x8X instead of 0xCX, it could be the issue.
Now, MCC tries to fix it with the timer, but the issue is still present, I will investigate.