fix lints reported by cargo check and clippy

crates/cardboard_oogl/examples/textured_cube.rs

@@ -70,7 +70,7 @@ fn main() {
     .set(&bound_program, &Mat4f::look_to_rh(CAMERA_POS, Vec3f::ZERO - CAMERA_POS, Vec3f::UP));
 
   let reset_viewport = |gl: &Context, window: &Window| {
-    common::reset_gl_viewport(&gl, &window);
+    common::reset_gl_viewport(gl, window);
     let (w, h) = window.drawable_size();
     let aspect = w as f32 / h as f32;
     uni_proj_mat.set(

crates/cardboard_oogl/src/buffer.rs

@@ -98,7 +98,7 @@ where
   T: Copy,
 {
   #[inline(always)]
-  fn object(&self) -> &VertexBuffer<T> { &self.buffer }
+  fn object(&self) -> &VertexBuffer<T> { self.buffer }
 
   fn unbind_completely(self) {
     self.ctx().bound_vertex_buffer.unbind_unconditionally(self.raw_gl());
@@ -206,7 +206,7 @@ where
   T: BufferIndex,
 {
   #[inline(always)]
-  fn object(&self) -> &ElementBuffer<T> { &self.buffer }
+  fn object(&self) -> &ElementBuffer<T> { self.buffer }
 
   fn unbind_completely(self) {
     self.ctx().bound_element_buffer.unbind_unconditionally(self.raw_gl());

crates/cardboard_oogl/src/context.rs

@@ -6,7 +6,7 @@ use prelude_plus::*;
 pub type SharedContext = Rc<Context>;
 impl Context {
   #[inline(always)]
-  pub fn share(self: &SharedContext) -> SharedContext { Rc::clone(&self) }
+  pub fn share(self: &SharedContext) -> SharedContext { Rc::clone(self) }
 }
 
 pub struct Context {

crates/cardboard_oogl/src/framebuffer.rs

@@ -55,7 +55,7 @@ pub struct FramebufferBinding<'obj> {
 
 unsafe impl<'obj> ObjectBinding<'obj, Framebuffer> for FramebufferBinding<'obj> {
   #[inline(always)]
-  fn object(&self) -> &Framebuffer { &self.framebuffer }
+  fn object(&self) -> &Framebuffer { self.framebuffer }
 
   fn unbind_completely(self) {
     self.ctx().bound_framebuffer.unbind_unconditionally(self.raw_gl());

crates/cardboard_oogl/src/shader.rs

@@ -342,7 +342,7 @@ impl Program {
     }
 
     let (location, data_type) =
-      check_uniform_type(&self, name, T::CORRESPONDING_UNIFORM_TYPES, type_name::<T>());
+      check_uniform_type(self, name, T::CORRESPONDING_UNIFORM_TYPES, type_name::<T>());
     Uniform { location, program_addr: self.addr, data_type, phantom: PhantomData }
   }
 
@@ -376,7 +376,7 @@ impl Program {
     }
 
     let (location, data_type) =
-      check_attrib_type(&self, name, T::CORRESPONDING_ATTRIB_TYPES, std::any::type_name::<T>());
+      check_attrib_type(self, name, T::CORRESPONDING_ATTRIB_TYPES, std::any::type_name::<T>());
     Attrib { location, program_addr: self.addr, data_type, phantom: PhantomData }
   }
 
@@ -396,7 +396,7 @@ pub struct ProgramBinding<'obj> {
 
 unsafe impl<'obj> ObjectBinding<'obj, Program> for ProgramBinding<'obj> {
   #[inline(always)]
-  fn object(&self) -> &Program { &self.program }
+  fn object(&self) -> &Program { self.program }
 
   fn unbind_completely(self) { self.ctx().bound_program.unbind_unconditionally(self.raw_gl()); }
 }

crates/cardboard_oogl/src/texture.rs

@@ -122,7 +122,7 @@ where
   T: TextureDataType,
 {
   #[inline(always)]
-  fn object(&self) -> &Texture2D<T> { &self.texture }
+  fn object(&self) -> &Texture2D<T> { self.texture }
 
   fn unbind_completely(self) { self.ctx().bound_texture_2d.unbind_unconditionally(self.raw_gl()); }
 }

src/globals.rs

@@ -29,7 +29,7 @@ pub struct Globals {
 
 impl Globals {
   #[inline(always)]
-  pub fn share(self: &SharedGlobals) -> SharedGlobals { Rc::clone(&self) }
+  pub fn share(self: &SharedGlobals) -> SharedGlobals { Rc::clone(self) }
 }
 
 #[derive(Debug)]

src/image_decoding_speedrun.rs

@@ -183,9 +183,14 @@ pub fn multi_threaded_main() -> AssetsMap {
   }
 
   let jobs_count = num_cpus::get();
-  let jobs: Vec<_> = (0..jobs_count)
-    .map(|i| asset_loading_job(i, Arc::clone(&assets), Arc::clone(&decoding_requests_recv_locked)))
-    .collect();
+  let mut jobs = Vec::<thread::JoinHandle<()>>::with_capacity(jobs_count);
+  for i in 0..jobs_count {
+    jobs.push(asset_loading_job(
+      i,
+      Arc::clone(&assets),
+      Arc::clone(&decoding_requests_recv_locked),
+    ))
+  }
 
   for path in asset_paths {
     decoding_requests_send.send(path).expect("decoding requests channel has been broken");

src/main.rs

@@ -196,8 +196,11 @@ fn try_main() -> AnyResult<()> {
 struct Game {
   pub globals: SharedGlobals,
 
+  #[allow(dead_code)]
   pub sdl_context: sdl2::Sdl,
+  #[allow(dead_code)]
   pub video_subsystem: sdl2::VideoSubsystem,
+  #[allow(dead_code)]
   pub sdl_gl_ctx: sdl2::video::GLContext,
   pub window: Window,
   pub event_pump: EventPump,

src/marching_squares.rs

@@ -369,5 +369,5 @@ fn copy_data_from_vec_into_buffer<'obj, Obj: 'obj, T>(
   } else {
     buffer.orphan_data();
   }
-  buffer.set_slice(0..data_vec.len(), &data_vec);
+  buffer.set_slice(0..data_vec.len(), data_vec);
 }

src/pong.rs

@@ -221,7 +221,7 @@ impl Pong {
       (&mut *left_racket, &mut *left_racket_controller),
       (&mut *right_racket, &mut *right_racket_controller),
     ] {
-      let dir = controller.get_movement_direction(&self.globals, &racket, &ball);
+      let dir = controller.get_movement_direction(&self.globals, racket, ball);
       racket.coll.accel.y = dir * RACKET_MAX_SPEED * RACKET_ACCELERATION;
     }