Add Typehints to project, Add a Context Manager for cleaning up aiodns and Add winloop support #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects to a NamedTuple For Speed and add slots on provider class objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like your project and I remember using it back in my early days. I'm going to try and see what I can provide to keep up with modern changes to python I also have my own dns-resolver called Cy-Ares Mean to fix the shortcomings of pycares in some newer ways but maybe we can add support for that project in the future when it begins to mature.
Winloop on the other hand is a newer library for python asyncio that is made to be the uvloop of windows operating systems. I use it heavily because standard python asyncio can be too slow sometimes, I altered one of the eventloop checks so winloop can be supported but you could actually get rid of this check all together since the event_thread argument for aiodns can make ProactorEventLoops work. If this pull-request is too big of a pill for you to swallow, I apologize.