-
Notifications
You must be signed in to change notification settings - Fork 18
Convenience methods proposal #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sdelaysam Thank you for the suggested improvements. The convenience issue is more complicated than it seems. For example, there is a need to write boilerplate code again or again like this |
|
@dmdevgo for me #46 decreased code readability. I like regular code |
Jeevuz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdelaysam Thanks for your proposals. We've discussed with @dmdevgo and I'm reviewed your changes and leaved comments with changes we ask you to make. Thanks in advance!
|
@Jeevuz done! |
|
@sdelaysam resolve conflicts, please |
# Conflicts: # sample/src/main/kotlin/me/dmdev/rxpm/sample/counter/CounterPm.kt
|
@dmdevgo done! |
|
@sdelaysam Thanks! |
@dmdevgo I'm considering your great framework to use in the next projects.
One thing that kinda bothers me is the need to write this code again and again
I understand this meant to unify the API but for end users it may be nice to have some convenience over it.