Skip to content

Automatic dark/light theming #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2024
Merged

Automatic dark/light theming #30

merged 4 commits into from
Oct 18, 2024

Conversation

dmackdev
Copy link
Owner

@dmackdev dmackdev commented Oct 17, 2024 •
edited
Loading

Closes #27.

  • Breaking: Moves colours from JsonTreeStyle into Option<JsonTreeVisuals>.
  • Exposes default light colour scheme JsonTreeVisuals::LIGHT.
  • Resolves default colour scheme to use based on egui::Visuals::dark_mode if JsonTreeStyle::visuals is not set.
  • Updates demo with theme preference radio buttons.
Screen.Recording.2024-10-17.at.19.28.42.mov

@dmackdev dmackdev marked this pull request as ready for review October 17, 2024 18:32
@dmackdev dmackdev merged commit 1d4c9ce into master Oct 18, 2024
2 checks passed
@dmackdev dmackdev deleted the auto-dark-light-theming branch October 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic light/dark theming
1 participant
@dmackdev