Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

Graphical customazation + fix drawing issue #285

Merged
merged 7 commits into from
May 27, 2017
Merged

Conversation

albinpoignot
Copy link
Contributor

Technical point of view :

  • Add attrs to be used in BarcodeScannerView
  • Pass the new attrs to ViewFinderView
  • Fix drawing lines issues (small offset on each corners due to the way Paint works)

Functionnal point of view :

  • Add graphical customization from the XML inflation of BarcodeScannerView
  • Fix corners drawing issue (small offset on each corner)

* Pass the new attrs to ViewFinderView
* Fix drawing lines issues (small offset on each corners)
@dm77
Copy link
Owner

dm77 commented Mar 22, 2017

Ah this is a good one. Has been on list of todos for 2.0 release that I have been holding back for a while now. Will merge this in with my changes. Thank you for this.

@albinpoignot
Copy link
Contributor Author

albinpoignot commented Mar 22, 2017

I just used Path instead of drawLine.It allows me to make rounded corners and potentially other customizations. You could wait a little longer until I pushed it before merging if you want too :)

@albinpoignot
Copy link
Contributor Author

Can one of the admin review this patch ?

@dm77 dm77 merged commit 0edb6f2 into dm77:master May 27, 2017
@dm77
Copy link
Owner

dm77 commented May 27, 2017

@albinpoignot This is now available in v1.9.3. Thank you so much:
a.) for waiting on me for 2 months to merge this commit
b.) for adding this very useful customization feature

Sorry for any trouble I caused you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants