Skip to content

Conversation

@AstrakhantsevaAA
Copy link
Contributor

Description

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

@netlify
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 4976a88
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/655b75b32d659500085dd127

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but please submit this PR from your private fork of dlt. why? because we need to check if the tests are really skipped. or did you test that is some other way?

@sh-rp sh-rp merged commit ad33225 into master Nov 22, 2023
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/fix_private_key branch November 22, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants