Skip to content

Conversation

@hibajamal
Copy link
Contributor

Description

Pushing the finalized Qdrant-zendesk code example.

Related Issues

  • Added Content, code, tests

Additional Context

  • none

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work @hibajamal! There are a few minor things that could be addressed for further improvement.

@hibajamal hibajamal force-pushed the docs/website/docs/examples/qdrant_eg branch from a6a7677 to 863a397 Compare November 23, 2023 12:29
@netlify
Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit a20af27
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65733280d277270008b44ed2

@AstrakhantsevaAA AstrakhantsevaAA changed the base branch from devel to master November 23, 2023 12:31
@hibajamal hibajamal force-pushed the docs/website/docs/examples/qdrant_eg branch 5 times, most recently from acab09e to 038dd4f Compare November 29, 2023 11:56
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's it, we're at the finish line, all that's left is to clean up and run the tests. If you have any questions, ask me 🤝

@hibajamal hibajamal force-pushed the docs/website/docs/examples/qdrant_eg branch from 9664169 to 6aa5a68 Compare December 7, 2023 14:06
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AstrakhantsevaAA @hibajamal thx for this! very neat example! please take a look at my review

@AstrakhantsevaAA AstrakhantsevaAA removed the request for review from adrianbr December 13, 2023 08:41
@AstrakhantsevaAA AstrakhantsevaAA dismissed stale reviews from rudolfix and burnash December 14, 2023 14:35

i don't want to bother him

@hibajamal hibajamal merged commit 2c1cd58 into master Dec 14, 2023
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/website/docs/examples/qdrant_eg branch December 14, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants