Skip to content

Conversation

@kaliole
Copy link
Contributor

@kaliole kaliole commented Oct 22, 2025

Upadte Installation page in dlthub documentation and add self-licensing section

@kaliole kaliole requested a review from VioletM October 22, 2025 14:13
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 22, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
docs 59cacc0 Commit Preview URL

Branch Preview URL
Oct 24 2025, 10:48 AM

Copy link
Contributor

@VioletM VioletM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several comments!


Find your installed licenses with:
```sh
$ dlt license show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the show command do? Verifying that you have a license? Why did you decide to remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no show command. I mixed it up because license info shows your installed licenses

runtime:
license: { env.MY_ENV_CONTAINING_LICENSE_KEY }
```sh
dlt license issue <scope>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be nice to describe what would happen when you run this command. If I'm not mistaken:

  1. License key would be printed to the cli output
  2. License key would be put in your toml file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it but was not able to double check whether this is true

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaliole this commit 094bd74

modified dlt main dependencies and adds js related files to the repository root. I think this may come from some experiments that you did on docs folder. please remove new dependencies from pyproject.toml and take uv.lock from devel to erase changes.

if the content of the docs is OK we can also take over this PR and clean it up. just ping me on docs channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants