-
Couldn't load subscription status.
- Fork 355
feat/3155 history #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArneDePeuter
wants to merge
18
commits into
dlt-hub:devel
Choose a base branch
from
ArneDePeuter:feat/3155-history
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat/3155 history #3156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/extract/test_history.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
historyfeature (see issue #3155), which allows transformers to access parent records directly whenkeep_history=Trueis set.This removes the need to explicitly propagate parent fields through every child transformer, simplifying pipelines and reducing schema clutter.
Implementation
keep_history=True, ahistorydictionary is made available to all subsequent nodes.keep_history=Truecontribute their data to this dictionary, ensuring that only the required information is retained.EMPTY_HISTORYobject. This avoids additional allocations and keeps the overhead negligible, since only a single immutable reference is passed around.The design follows a similar approach to the existing
metafeature for consistency.Comprehensive tests have been added to validate the behavior of this new feature.
Tiny Additional Proposal
As a follow-up improvement, we could simplify function signatures by removing the need for explicit
= Nonedefaults.For example, instead of writing:
we could allow:
This would make transformer definitions cleaner and reduce boilerplate in function signatures.