Skip to content

Conversation

@anuunchin
Copy link
Contributor

@anuunchin anuunchin commented Sep 9, 2025

This PR adds introduces the following two commands in the main makefile:

  1. build-marimo
  2. lint-marimo

Both of them are included in the docs linting workflow.

Since marimo convert doesn't allow variable redefinitions and renames redefined variables, some of the converted files may not work as expected. However, I think this is a good approach due to the reason mentioned in marimo docs:

That's (variable redefinition) a problem because it creates hidden state and hidden bugs, and it's part of the reason why over 96% of Jupyter notebooks on GitHub aren't reproducible.

  • Therefore, we should remove variable redefinitions in the original notebooks.

Another limitation of marimo convert is that it doesn't convert magic commands (e.g. !pip install dlt). This not exactly a 'limitation', since marimo supports a proper package handling.

  • Therefore, we should maybe add a comment to the magic command cells that libraries should be added by the marimo package manager.

Resolves the third part in #2969

@anuunchin anuunchin self-assigned this Sep 9, 2025
@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 93fc02f
🔍 Latest deploy log https://app.netlify.com/projects/dlt-hub-docs/deploys/68c00d96ed3ca80008cbba6a
😎 Deploy Preview https://deploy-preview-3068--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@anuunchin anuunchin force-pushed the feat/ed-content-marimo branch from 93fc02f to 9641a3d Compare October 2, 2025 09:55
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
docs 896d380 Commit Preview URL

Branch Preview URL
Oct 07 2025, 10:00 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant