helper to filter dlt-changes out of schema updates #2968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
djudjuu
force-pushed
the
feat/schema/helper-to-get-update-without-dlt-changes
branch
from
c87cb24 to
db18d38
Compare
rudolfix
requested changes
Aug 26, 2025
There was a problem hiding this comment.
we need several improvements so this PR makes sense:
- extract a method
is_dlt_table_or_columnthat checks if name has a prefix. I know this is simple but since we already have many places that needs it - it makes sense - see how it is done in Schema and replace all the checks with function above
- extract a function that
cleanssingle table - taking dictionary as input is constraining. take Iterable of table schemas
- where is the test?
| return data_tables, dlt_tables | ||
|
|
||
|
|
||
| def changes_without_dlt_changes( |
There was a problem hiding this comment.
this name was correct in context of callback function. here it just removed "dlt entities" from a list of tables. so (1) it needs a different name (2) it makes sense to split it into many functions. see my general review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of the callbacks in dlt+ I wrote some helper methods that allow to filter out dlt-tables and columns from all the changes that occured during a schema migration (TTableSchema is used in the load-package info of the trace.. Most likely the user will only care about non-dlt changes and these helpers can be used to display just those.
this pr adds a helper that can filter out dlt-tables or columns from these schema migrations, parameterizable by dlt_column and _table prefix, which could be different.