(feat) allows to add SQL statements to schema migration executed after tables were created/altered #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
force-pushed
the
feat/allows-to-override-update-sql
branch
from
8ac2fd9 to
d44ccb9
Compare
burnash
reviewed
Jun 20, 2025
burnash
reviewed
Jun 20, 2025
Comment on lines
+674
to
+677
| for sql in post_sql_statements: | ||
| if not sql.endswith(";"): | ||
| sql += ";" | ||
| post_sql_updates.append(sql) |
There was a problem hiding this comment.
It's best to extract this into a utility method, can do as a follow-up PR.
burnash
approved these changes
Jun 20, 2025
|
@rudolfix and we'd need a test for it. |
dat-a-man
pushed a commit
that referenced
this pull request
Jun 24, 2025
…r tables were created/altered (#2791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to override
_get_table_post_update_sqlin sql job client. The intended usage is to add additional statements (ie. foreign references) that must be executed after all tables were created/altered.