Prevent options leaking between compilations #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2016
Currently options are leaking between compilation runs. This is most evident when using an array of importers. The array is shallow copied internally, and the children of that array are wrapped by Node Sass. When the next file is compiled the options are shallow copied once again however this time the importer array contains the wrapped importers not the original ones. Instead of shallow copying with `Object.assign` this patch does a full deep clone. Node Sass should also do this to prevent mutating the options being passed in. Related sass/node-sass#1168 Fixes dlmanning#467 (probably)
xzyfer
force-pushed
the
fix/option-leakage
branch
from
32f694a
to
035b759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently options are leaking between compilation runs. This is most
evident when using an array of importers. The array is shallow copied
internally, and the children of that array are wrapped by Node Sass.
When the next file is compiled the options are shallow copied once
again however this time the importer array contains the wrapped
importers not the original ones.
Instead of shallow copying with
Object.assignthis patch does afull deep clone. Node Sass should also do this to prevent mutating
the options being passed in.
Related sass/node-sass#1168
Fixes #467 (probably)