Skip to content

Conversation

@ericbn
Copy link
Contributor

@ericbn ericbn commented Nov 30, 2022

Fixes #56

@Finkregh
Copy link

any ETA on this?

@mschwager mschwager self-requested a review January 25, 2023 14:25
@mschwager
Copy link
Contributor

Hi there, sorry for the delay. I wonder why CI isn't running on this PR?

@ericbn
Copy link
Contributor Author

ericbn commented Jan 25, 2023

Hi. No idea why the CI didn't run. Let me force push the commit to try to trigger it.

@ericbn
Copy link
Contributor Author

ericbn commented Jan 25, 2023

I got:

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.

@mschwager
Copy link
Contributor

I've got CI passing on master again. Please rebase to get CI passing on this PR.

However, now that I'm looking through the flake8 release notes I'm seeing that Python 3.8.1 is the minimum supported version. I believe this change is still okay because it simply removes the upper bound on the flake8 version. I think CI will pass because older versions of Python can use older versions of flake8.

I've got to drop Python 3.6 and add 3.11, but I can work on that after this PR.

@ericbn
Copy link
Contributor Author

ericbn commented Jan 27, 2023

Thanks for looking into this. It's done, branch rebased. Got this warning again:

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.

@mschwager
Copy link
Contributor

I've fixed the latest CI errors. Can you try again?

@ericbn
Copy link
Contributor Author

ericbn commented Jan 27, 2023

Cool, thanks! Rebased again.

@mschwager
Copy link
Contributor

Annnnnnd we're back! Thanks for your patience!

@mschwager mschwager merged commit 1e0faa4 into dlint-py:master Jan 27, 2023
@ericbn ericbn deleted the patch-1 branch January 27, 2023 15:35
@jabbera
Copy link

jabbera commented Feb 6, 2023

Any idea when we can get a release of this?

@mschwager
Copy link
Contributor

Done! https://pypi.org/project/dlint/0.14.0/

@jabbera
Copy link

jabbera commented Feb 7, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flake8 v6 compatibility

4 participants