Fix off-by-one in skill tooling paths (../../ -> ../../../) - #1
Open
xakaxari wants to merge 1 commit into
Open
Conversation
SKILL.md files referenced shared tooling as ${CLAUDE_SKILL_DIR}/../../bin
and ${CLAUDE_SKILL_DIR}/../../scripts. Skills live at
<repo>/.claude/skills/<skill>/, so ../../ resolves to <repo>/.claude/, which
contains only skills/. The real bin/ and scripts/ are at the repo root, one
level further up, so every one of these references pointed at a path that
does not exist and any skill shelling out to them failed.
Rewrite the 60 affected references to ../../../ across 12 files. All 95
${CLAUDE_SKILL_DIR} tooling references in the tree now resolve against disk.
References of the form ${CLAUDE_SKILL_DIR}/scripts/... point at a skill's own
directory and were already correct; they are left alone.
Still present upstream as of 0732956.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SKILL.mdfiles reference shared tooling as:Skills live at
<repo>/.claude/skills/<skill>/, so${CLAUDE_SKILL_DIR}/../../resolves to<repo>/.claude/— which contains onlyskills/. The realbin/andscripts/are at the repo root, one level further up.Every one of these references points at a path that does not exist, so any skill shelling out to
bin/construction-pythonorscripts/**fails.Fix
Rewrite the 60 affected references to
../../../across 12 files.References of the form
${CLAUDE_SKILL_DIR}/scripts/...point at a skill's own directory and were already correct; those are left alone.Verification
Resolved all 95
${CLAUDE_SKILL_DIR}tooling references in the tree against disk: 0 unresolved (60 unresolved before the change).Spot-checked by running
bin/construction-pythonandscripts/issue_manager.pythrough a skill path on Windows 11.Most affected:
rfi-drafter(12),schedule-extractor(9),subcontract-writer(6),bid-tabulator(6).🤖 Generated with Claude Code