lightweight cli output update

[leoebfolsom]

My attempt at improving the CLI printout without using any additional python packages.

BEFORE:

AFTER:

[erezsh]

Looks like _get_stats_dbt() should instead just be a flag to _get_stats()

[erezsh]

Better to implement this using zip() / safezip()

[leoebfolsom]

Thanks for the tip @erezsh that's new to me, I'll try it out.

[leoebfolsom]

@erezsh I'll try updating it to add a _get_stats() flag 👍

What do you suggest is the best way to determine that the --dbt flag was part of the data-diff command, so that I can apply if/then logic? In other words, within _get_stats_dbt():

if x:
  my updated output
else:
  the current output

What would x be?

[erezsh]

I don't understand the question. The flag exists in main, so it has to be passed along somehow.

[leoebfolsom]

@erezsh ok, I'll figure it out and get back to you. I thought you might know off the top of your head how it is passed along.

[dlawin]

Could keep it simple and do something like:

def get_stats_string(self, is_dbt:bool = False):

In dbt.py:
diff.get_stats_string(is_dbt=True)

[dlawin]

Then there's no need to duplicate the logic in _get_stats()

You can add the additional functionality there and just wrap it in an if is_dbt:

[leoebfolsom]

Thanks @dlawin and @erezsh for the feedback. I need to sign off for a few and I'll be off on Friday and Monday, but I may get to at least some of this tonight. 🥳