Fix bugzilla 24596: std.typecons.Rebindable2: Don't destroy classes! Only destroy structs!

[FeepingCreature]

PR fixes #8768 for classes.

object.destroy is, perhaps appropriately, the most destructive function ever written.

It does something useful (resetting the value and calling the destructor) for structs and struct derivatives, but something horrible (destroying the class data) for objects. So you're always tempted to use it, but you have to remember, every time, to disable the cases where it silently causes future crashes.

I forgot this time.

edit: core.internal.container.common.destroy looks like it does it right... Maybe I just switch to that? Is that safe to call from std.typecons?

[dlang-bot]

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	24596	critical	Rebindable2 corrupts objects

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9012"