Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.uni: optimize simpleCaseTable #8878

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 6, 2024

Cuts size of simpleCaseTable entries in half (8 -> 4 bytes), reducing table size from 24 Kb to 12 Kb. Still only 22 out of 32 bits per entry are actually used, so could be optimized further. Using plain integers saves 10 ms semantic2 compile time.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8878"

@rikkimax
Copy link
Contributor

rikkimax commented Jan 6, 2024

Certainly better, but I am surprised it has only got 10ms off.

@dkorpel
Copy link
Contributor Author

dkorpel commented Jan 6, 2024

The FullCaseEntry table is 50 kb currently, I expect optimizing that to shave off another 20 ms.

@dkorpel dkorpel force-pushed the unicode-sce branch 5 times, most recently from 172b64e to 568778c Compare January 7, 2024 23:03
@dkorpel dkorpel requested a review from wilzbach as a code owner January 7, 2024 23:03
Cuts size of simpleCaseTable entries in half (8 -> 4 bytes), reducing table size from 24 Kb to 12 Kb.
Still only 22 out of 32 bits per entry are actually used, so could be optimized further.
Using plain integers saves 10 ms semantic2 compile time.
@dkorpel
Copy link
Contributor Author

dkorpel commented Jan 9, 2024

Ping

@dlang-bot dlang-bot merged commit 135e9ad into dlang:master Jan 9, 2024
13 checks passed
@dkorpel dkorpel deleted the unicode-sce branch January 9, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants