Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Fix assumeUnique RUNNABLE_EXAMPLE tests #8611

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Oct 17, 2022

These get wrapped in void main {...} by both dspec_tester.d and run_examples.js. Workaround this.

Note: I'm working on extracting tests for Phobos RUNNABLE_EXAMPLE, but currently these are not tested. This is the 2nd and last change needed for that to work.

These get wrapped in `void main {...}` by both dspec_tester and
run_examples.js. Workaround this.
@ntrel ntrel requested a review from andralex as a code owner October 17, 2022 15:32
@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label Oct 17, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8611"

@dlang-bot dlang-bot merged commit 6f62de0 into dlang:master Oct 17, 2022
@ntrel ntrel deleted the assumeUnique-fix branch October 18, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:auto-merge Review:Trivial typos, formatting, comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants