Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 14543: std.algorithm.searching.until does n… #8570

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Fix issue 14543: std.algorithm.searching.until does n… #8570

merged 1 commit into from
Sep 26, 2022

Conversation

jamesragray
Copy link

…ot handle range sentinels nicely. This may break user code, unlike (#8568)

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 16, 2022

Thanks for your pull request and interest in making D better, @jamesragray! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
14542 minor Table of contents in specification PDF is broken

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8570"

@pbackus
Copy link
Contributor

pbackus commented Sep 17, 2022

Thanks! Looks like everything's green on buildkite, so maybe we can get away with this.

@jamesragray jamesragray marked this pull request as ready for review September 19, 2022 10:29
@thewilsonator
Copy link
Contributor

(assuming this fixes the issue in question) please amend the commit title to be Fix issue 14543: <issue title goes here> so the bot picks it up properly.

@jamesragray jamesragray changed the title Alternative fix for issue 14543: std.algorithm.searching.until does n… Fix issue 14543: std.algorithm.searching.until does n… Sep 20, 2022
@RazvanN7
Copy link
Collaborator

@jamesragray Simply changing the title will not get the bot to pick this up. You need to make a new commit that contains "Fix Issue 14543" in its commit message so that the bot knows to close the bugzilla entry automatically and so that you get bugzilla points that you can see on the leaderboards [1][2] (you can even win prizes, for more info check this blog post[3]). You need to:

git commit --amend -m "Fix Issue 14542 - std.algorithm.searching.until does not handle range sentinels nicely"
git push $your_branch $your_remote_repo

[1] https://bot.dlang.io/contributor_stats
[2] https://bot.dlang.io/contributor_stats_cycle
[3] https://dlang.org/blog/2021/09/16/bugzilla-reward-system/

@RazvanN7 RazvanN7 merged commit 88aa69b into dlang:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants