Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix Issue 9489 - writeln of struct with disabled copy ctor" #8092

Merged
merged 2 commits into from
May 18, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 17, 2021

Reverts #8055

@dlang-bot
Copy link
Contributor

dlang-bot commented May 17, 2021

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
9489 normal writeln of struct with disabled copy ctor
21920 regression [REG master] Error: auto can only be used as part of auto ref for template function parameters

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8092"

@ibuclaw
Copy link
Member Author

ibuclaw commented May 17, 2021

@Geod24 @thewilsonator mind if I also commit a unittest for 21920?

@Geod24
Copy link
Member

Geod24 commented May 17, 2021

Of course not :)

@ibuclaw
Copy link
Member Author

ibuclaw commented May 17, 2021

Done! 28e3352

(Edit: Oops, put it in the wrong unittest block)

@RazvanN7
Copy link
Collaborator

Doesn't this also fix 21920?

@ibuclaw
Copy link
Member Author

ibuclaw commented May 17, 2021

@RazvanN7 added "fix" to the commit message.

@Geod24
Copy link
Member

Geod24 commented May 17, 2021

No, the offending commit is not in stable.

@RazvanN7
Copy link
Collaborator

No, the offending commit is not in stable.

Wow, it's like you read my mind. I did think of suggesting to target stable, but then realized that the offending commit got merged last week. 10 seconds later I see "No, the offending commit is not in stable"

@ibuclaw
Copy link
Member Author

ibuclaw commented May 17, 2021

The issue says REG master not REG stable. ;-)

@CyberShadow
Copy link
Member

Of course, sorry for the noise :)

@ibuclaw
Copy link
Member Author

ibuclaw commented May 17, 2021

Who broke the test-suite?

generated/linux/release/64/benchmark.o:benchmark/runbench.d:function _D8runbench8runTestsFSQu6ConfigZv:
error: undefined reference to '_D3std4path12absolutePathFNaNfAyaLQeZQh'
--
generated/linux/release/64/benchmark.o:benchmark/runbench.d:function _D8runbench8runTestsFSQu6ConfigZv:
error: undefined reference to  '_D3std4path12absolutePathFNaNfAyaLQeZQh'

@ibuclaw ibuclaw force-pushed the revert-8055-issue_9489 branch from baf64db to c162202 Compare May 17, 2021 21:06
@dlang-bot dlang-bot merged commit 862c392 into master May 18, 2021
@ibuclaw ibuclaw deleted the revert-8055-issue_9489 branch May 18, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants