Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FreeBSD x86 reals #7689

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Add support for FreeBSD x86 reals #7689

merged 4 commits into from
Nov 13, 2020

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Nov 9, 2020

These are changes based off the dmd-cxx branch, so there may be a few more cases that need to be dealt with in master, however this is enough for 32-bit FreeBSD to compile and initially pass all phobos unittests.

@ibuclaw ibuclaw added the math label Nov 9, 2020
@ibuclaw ibuclaw requested a review from thewilsonator November 9, 2020 13:34
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7689"

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 9, 2020

Hmm, hold up for a while, it looks like there was a bug in the druntime asm code (dlang/druntime#3266), so I'll have to re-run this again on 32-bit FreeBSD to find out if anything done here has been made redundant.

@ibuclaw ibuclaw marked this pull request as draft November 9, 2020 14:49
@ibuclaw ibuclaw marked this pull request as ready for review November 10, 2020 12:19
@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 10, 2020

Hmm, hold up for a while, it looks like there was a bug in the druntime asm code (dlang/druntime#3266), so I'll have to re-run this again on 32-bit FreeBSD to find out if anything done here has been made redundant.

FPU setting was removed, so this PR is fine as-is for 53-bit precision on 80-bit reals.

@ibuclaw ibuclaw requested a review from n8sh November 10, 2020 12:21
@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 10, 2020

FYI @kinke

@ibuclaw ibuclaw mentioned this pull request Nov 11, 2020
Closed
@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 13, 2020

Any cause for concern here?

@12345swordy
Copy link

I don't see any issue here.

Geod24
Geod24 reviewed Nov 13, 2020
View reviewed changes
std/complex.d
version (StdUnittest)
{
// Helper function for comparing two Complex numbers.
int ceqrel(T)(const Complex!T x, const Complex!T y) @safe pure nothrow @nogc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you just moved it, nvm

@Geod24 Geod24 merged commit e89d9d9 into dlang:master Nov 13, 2020
@ibuclaw ibuclaw deleted the real80round53 branch November 13, 2020 20:22
@ibuclaw ibuclaw mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@Geod24 Geod24 Geod24 approved these changes

@JackStouffer JackStouffer Awaiting requested review from JackStouffer

@kyllingstad kyllingstad Awaiting requested review from kyllingstad

@n8sh n8sh Awaiting requested review from n8sh

Assignees
No one assigned
Labels
math
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ibuclaw @dlang-bot @12345swordy @Geod24 @thewilsonator