Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min must be stable #7605

Merged
merged 1 commit into from
Aug 28, 2020
Merged

min must be stable #7605

merged 1 commit into from
Aug 28, 2020

Conversation

andralex
Copy link
Member

Sigh. Every time I get back to looking at things, code is more complicated.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 23, 2020 •
edited
Loading

Thanks for your pull request, @andralex!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 21191 normal min should be stable: when in doubt, return the first argument

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7605"

@andralex andralex mentioned this pull request Aug 23, 2020
Merged
@wilzbach
Copy link
Member

wilzbach commented Aug 23, 2020 •
edited by andralex
Loading

  • tests to avoid regressions
  • issue reference for the changelog

@andralex
Copy link
Member Author

I created an issue: https://issues.dlang.org/show_bug.cgi?id=21191

@dlang-bot dlang-bot merged commit 6194b17 into dlang:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8sh n8sh n8sh approved these changes

@JackStouffer JackStouffer Awaiting requested review from JackStouffer

@wilzbach wilzbach Awaiting requested review from wilzbach

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andralex @dlang-bot @wilzbach @n8sh