Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent quickindex wrapper around hand-written list-of-links t… #7401

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

adamdruppe
Copy link
Contributor

…ables

About half the files did it one way and half did it another way. See:

https://dlang.org/phobos/std_algorithm.html
vs
https://dlang.org/phobos/std_encoding.html

for example. Whereas the handwritten list of links is semantically a quickindex the same as the auto-generated version, I decided to consistently apply that quickindex class throughout, so going with what std.algorithm (and std.math, std.ascii, and std.net.curl, among other random modules) has now extended consistently to all of them.

Note that I did NOT apply this to all the std.algorithm submodule "cheat sheets" because those tables are not just a list of links, those are more prose-y than list-y.

Then we can also change style on them consistently, if desired in the future, with one css rule without affecting other tables.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @adamdruppe! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7401"

@wilzbach wilzbach merged commit 7a656e0 into dlang:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants