-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix std.format FP printing for soft-float targets #7377
Conversation
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7377" |
Instead of importing |
The local import only affects the little |
That "little |
AFAIK, the only difference for a whole import here is the namespace pollution, but as long as that's restricted to a little import std.math : isFloatingPointControlAvailable;
static if (isFloatingPointControlAvailable)
{
import std.math : FloatingPointControl;
...
} much uglier. |
For me both is fine. |
Yeah maybe this wasn't a good rule since it defeats this kind of compile time introspection. |
The rules can be selectively disabled in .dscanner.ini |
Does the bot ignore the 72h... label? |
Yes, the label is just for humans. |
After #7362.