Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 20500 - running examples on the home page only displays '1 … #7359

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

rainers
Copy link
Member

@rainers rainers commented Jan 23, 2020

…unittests passed'

move unittests out of templated struct FormatSpec so they are not generated when using the template

@rainers rainers requested a review from andralex as a code owner January 23, 2020 07:21
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
20500 major running examples on the home page only displays '1 unittests passed'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7359"

@thewilsonator
Copy link
Contributor

I'm not sure why this is mark major, but it is, so should it target stable?

@rainers
Copy link
Member Author

rainers commented Jan 23, 2020

I'm not sure why this is mark major, but it is, so should it target stable?

Do you mean it should target master? I think it's pretty bad that the examples don't work properly on the website, but simple user code as

import std.stdio;
void main()
{
	writefln("The answer is %d", 42);
}

doesn't run when compiled with -unittest. This doesn't work as advertised (run main if there are no unittests).

@thewilsonator
Copy link
Contributor

Derp, ignore that. I can't read.

…unittests passed'

move unittests out of templated struct FormatSpec so they are not generated when using the template
@wilzbach
Copy link
Member

The Buildkite failures are unrelated and due to new agents without a full config being recently added.

@wilzbach wilzbach merged commit 9f47cc2 into dlang:stable Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants