Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] std.typecons: Get rid of unnecessary core.stdc.stdint.uintptr_t import #6639

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jul 19, 2018

Importing std.algorithm and std.range would previously import these core.stdc.* modules:

  • core.stdc.stdint
  • core.stdc.config
  • core.stdc.stddef
  • core.stdc.signal
  • core.stdc.wchar_
  • core.stdc.stdarg
  • core.stdc.stdio
  • core.stdc.time

With this, only core.stdc.stdarg remains.

This is a big deal for bare-metal platforms without C libs, e.g., WebAssembly. See https://forum.dlang.org/post/threqzyvtpspkxhrvjnb@forum.dlang.org.

Importing std.algorithm and std.range would previously import these
core.stdc.* modules:

core.stdc.stdint
core.stdc.config
core.stdc.stddef
core.stdc.signal
core.stdc.wchar_
core.stdc.stdarg
core.stdc.stdio
core.stdc.time

With this, only core.stdc.stdarg remains.

This is a big deal for bare-metal platforms without C libs, e.g.,
WebAssembly.
@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label Jul 19, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6639"

@kinke kinke changed the title [Trivial] std.typecons: Get rid of unnecessary core.stdc.uintptr_t import [Trivial] std.typecons: Get rid of unnecessary core.stdc.stdint.uintptr_t import Jul 19, 2018
@wilzbach wilzbach merged commit bcedaf1 into dlang:master Jul 19, 2018
@kinke kinke deleted the typecons branch July 21, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:auto-merge Review:Trivial typos, formatting, comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants