Fix Issue 18044: std.conv.to for implicitly convertible associative arrays

[John-Colvin]

No description provided.

[dlang-bot]

Thanks for your pull request, @John-Colvin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close	Bugzilla	Description
✓	18044	std.conv.to for implicitly convertible associative arrays

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

[schveiguy]

LGTM. Can you make a bugzilla entry so it gets in the changelog?

[John-Colvin]

https://issues.dlang.org/show_bug.cgi?id=18044

[wilzbach]

The issue number needs to be mentioned in the git commit message. You can verify this is the bot lists the issue. I'm currently on the road, so I just removed auto-merge. Sorry

[John-Colvin]

@wilzbach is that documented anywhere? I always forget what I'm supposed to do.

[wilzbach]

Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Yes, just read the bot's comment.

[John-Colvin]

Yes, I know I needed to make a bugzilla entry, I was just being lazy. The bot doesn't tell me anything about how and where to reference the issue once created.

Have I done it the right way now?

[wilzbach]

Yes, I know I needed to make a bugzilla entry, I was just being lazy. The bot doesn't tell me anything about how and where to reference the issue once created.

It does. Just follow the referenced link: https://github.com/dlang-bots/dlang-bot#automated-references

Have I done it the right way now?

Nope. As said once the git message references the issue, the bot will update its comment and you will see a table listing the issue.

[wilzbach]

Nope. As said once the git message references the issue, the bot will update its comment and you will see a table listing the issue.

I think you just need to remove the colon :
The RegExp for detecting the issues is on the Bugzilla side. Nothing we can do about this.

[John-Colvin]

Ah, ok, thanks. Sorry, I read the "reference a Bugzilla issue" section in your quote and missed that in the original it had a link.

[wilzbach]

I am sorry for the horrible help - I usually could have simply force-pushed the commit message, but unfortunately it's a bit hard without a computer. Glad you managed to win the fight against the bot :)

[schveiguy]

The issue number needs to be mentioned in the git commit message.

Is this a requirement for it to get in the changelog? I knew this wasn't going to auto close, but I was just going to close it manually in this case :)

[wilzbach]

Is this a requirement for it to get in the changelog? I knew this wasn't going to auto close, but I was just going to close it manually in this case :)

Yes, I assume no one read the Readme of the bot or the wiki entry?
tl;dr: the GitHub Bugzilla integration handles closing the issues, the dlang/tools/changed.d script parses the git log between two releases only. Hence, if the issue isn't mentioned in the git log, it won't appear in the log.
BTW since a couple of months it's possible to preview the changelog on DAutoTest: http://dtest.dlang.io/artifact/website-bb685c0e96626967d952e71a0ef838246140b3c1-67c70e66687de80247893d87d6f0b012/web/changelog/2.078.0_pre.html or on https://dlang.org/changelog/2.078.0_pre.html, but issues will only be displayed if they are closed, that's why there are no changes listed on DAutoTest.

[schveiguy]

Yes, I assume no one read the Readme of the bot or the wiki entry?

You assumed correctly :) I am a lazy programmer after all...

Honestly, I didn't realize this had anything to do with git, I just thought the changelog consisted of closed bugs in the time between releases. But the way it is makes a hell of a lot more sense -- some bugs are closed as "WORKSFORME", which have nothing to do with the release.