Fix long lines in Phobos

[wilzbach]

The Dscanner check for long lines turned out to be erroneous (see e.g. dlang-community/D-Scanner#465 or dlang-community/D-Scanner#440)

Hence, some bits of Phobos kept hidden.

Unfortunately I don't know a good way to deal with std/datetime/timezone.d (the parser expects every item to be on a single line), but in the worst case we can now (#5495) always do -std.datetime.timezone

Any ideas @jmdavis?

[wilzbach]

Hmm I realized that merging the fix into the phobos branch at Dscanner without ensuring that Phobos works the the fixed long line check, wasn't a good idea as by checking out a branch instead of a version/commit, the latest checkout will always be propagated to all CircleCI builds here and lead to unrelated failures (the circle.sh script merges the PR branch into upstream/master at the beginning).
Hence, I excluded std.datetime.timezone for now and changed the Makefile to checkout a specific Dscanner commit, so that we can quickly move ahead here.

@jmdavis for reference, the diff was:

diff --git a/std/datetime/timezone.d b/std/datetime/timezone.d
index 0b3bfa74e..29b3fd5f7 100644
--- a/std/datetime/timezone.d
+++ b/std/datetime/timezone.d
@@ -3485,7 +3485,8 @@ For terms of use, see http://www.unicode.org/copyright.html
 
             <!-- (UTC-09:00) Alaska -->
             <mapZone other="Alaskan Standard Time" territory="001" type="America/Anchorage"/>
-            <mapZone other="Alaskan Standard Time" territory="US" type="America/Anchorage America/Juneau America/Nome America/Sitka America/Yakutat"/>
+            <mapZone other="Alaskan Standard Time" territory="US"
+                type="America/Anchorage America/Juneau America/Nome America/Sitka America/Yakutat"/>
         </mapTimezones>
     </windowsZones>
 </supplementalData>`;

[CyberShadow]

changed the Makefile to checkout a specific Dscanner commit

Tags would be a bit nicer.

Unfortunately I don't know a good way to deal with std/datetime/timezone.d

Well, you could just update the example and the unit test. That particular line seems to be there to test splitting multiple entries by space, so you can pick any other line from the file it was reduced from that has multiple entries but is under the line length limit.

Though, I think the line length checks should only apply to code that CAN be reasonably split into multiple lines, which doesn't apply to WYSIWYG string literals.

[CyberShadow]

Going to merge this as I understand it unbreaks CircleCI.

[wilzbach]

Tags would be a bit nicer.

Tags will be visible for the entire Dscanner repo, so I guess I would then get complaints from other people about tags not being nice ;-)
I hope that maintaining the phobos branch is only a temporary solution anyways and that my changes make it to master.

Well, you could just update the example and the unit test. That particular line seems to be there to test splitting multiple entries by space, so you can pick any other line from the file it was reduced from that has multiple entries but is under the line length limit.

Hehe, I have the philosophy: "One shall never touch existing tests!"

Though, I think the line length checks should only apply to code that CAN be reasonably split into multiple lines, which doesn't apply to WYSIWYG string literals.

Not sure about this, but that's a discussion for a different day ...
Feel free to open an issue at Dscanner if you feel strongly about this.

Going to merge this as I understand it unbreaks CircleCI.

Yes. Thanks!