Skip to content

Fix CircleCi: auto functions that return null should be void #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2017
Merged

Fix CircleCi: auto functions that return null should be void #5215

merged 1 commit into from
Feb 28, 2017

Conversation

wilzbach
Copy link
Member

As CircleCi builds doesn't get re-run, there's the slight potential that master has evolved. This has just happened with the newly enabled Dscanner check in #5160

tl;dr: std.experimental.checkedint has two auto function that don't return a value.

@JackStouffer
Copy link
Member

Auto-merge toggled on

@wilzbach wilzbach mentioned this pull request Feb 28, 2017
Merged
@JackStouffer JackStouffer merged commit c337bbf into dlang:master Feb 28, 2017
@wilzbach wilzbach deleted the fix-circleci2 branch February 28, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackStouffer JackStouffer JackStouffer approved these changes

Assignees

@andralex andralex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilzbach @JackStouffer @andralex