Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 17154 – Add opDollar to std.conv.toChars #5081

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix Issue 17154 – Add opDollar to std.conv.toChars #5081

merged 1 commit into from
Feb 10, 2017

Conversation

JackStouffer
Copy link
Member

No description provided.

@JackStouffer JackStouffer added the Review:Trivial typos, formatting, comments label Feb 1, 2017
@JackStouffer JackStouffer changed the title Add opDollar to std.conv.toChars Fix Issue 17154 – Add opDollar to std.conv.toChars Feb 7, 2017
@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
✓ 17154 std.conv.toChars doesn't support $ in slicing

DmitryOlshansky
DmitryOlshansky approved these changes Feb 8, 2017
View reviewed changes
Copy link
Member

@DmitryOlshansky DmitryOlshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

@WalterBright
Copy link
Member

In the future, please use more descriptive branch names than patch-2 which gives no clue what it is about. For example, see https://auto-tester.puremagic.com/pulls.ghtml?projectid=1

@WalterBright WalterBright merged commit d8ca218 into master Feb 10, 2017
@JackStouffer JackStouffer deleted the JackStouffer-patch-2 branch February 12, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

@DmitryOlshansky DmitryOlshansky DmitryOlshansky approved these changes

Assignees
No one assigned
Labels
Review:Trivial typos, formatting, comments Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JackStouffer @dlang-bot @DmitryOlshansky @WalterBright @PetarKirov