-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nthPermutation #5068
nthPermutation #5068
Conversation
727c7a1
to
6d272d5
Compare
6d272d5
to
39d43f4
Compare
CircleCi fails due to style checks:
|
39d43f4
to
fc917c7
Compare
fc917c7
to
f6ca47c
Compare
@quickfur are you at dconf? |
Sadly, no. :-( |
@andralex this contains a new public symbol |
Name addition is okay. |
d4c80f9
to
7d0d584
Compare
Thanks for your pull request, @burner! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#5068" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still believe that decimalToFactorial
should go to std.numeric
d9766f8
to
0fef146
Compare
finally found some time to move decimalToFactorial to numeric. @wilzbach @JackStouffer @andralex can we move on this now? |
988833b
to
7496765
Compare
add the function nthPermutation that permutates a given range in place n permutations in O(1). This is O(n - 1) steps faster than calling nextPermutation n times.
7496765
to
ca36812
Compare
Moving on. |
@thewilsonator thank you |
comments addressed
No problems |
sorts a given range in constant time into its nth permutation. Using the factorial number system and Lehmer codes