Fix Issue 16443 - Segmentation fault when option name is empty #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@jdeschenes, thanks for your PR! By analyzing the annotation information on this pull request, we identified @andralex, @burner and @AndrejMitrovic to be potential reviewers. @andralex: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
| @@ -671,6 +673,11 @@ private void getoptImpl(T...)(ref string[] args, ref configuration cfg, | |||
| { | |||
| // it's an option string | |||
| auto option = to!string(opts[0]); | |||
| if (option.length == 0) | |||
| { | |||
| excep = new GetOptException("An option may not be an empty string", excep); | |||
There was a problem hiding this comment.
4 spaces after indentation please (there's 2).
|
LGTM except the indentation. |
If the option name is an empty string an Exception will be raised instead.
jdeschenes
force-pushed
the
empty_getopt
branch
from
fcd4c0f to
024b751
Compare
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent a segmentation fault when the option name is empty.
I am not convinced the type of Exception is correct since this is not a user error, but a programming error.
Comments are appreciated.