Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Improved docs for std.conv.parse (part 4) #4633

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

JackStouffer
Copy link
Member

No description provided.

@qznc
Copy link
Contributor

qznc commented Jul 26, 2016

LGTM

@@ -3275,7 +3275,20 @@ Target parse(Target, Source)(ref Source s)
assert(b == true);
}

// input range to null literal conversions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this function wasn't exposed to the user before. Is there a good use case where a user might need this explicit documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No public function should be undocumented. If the user is supposed to be able to use it, then they should know about it.

@JackStouffer JackStouffer changed the title Improved docs for std.conv.parse (part 4) [trivial] Improved docs for std.conv.parse (part 4) Aug 17, 2016
@JackStouffer
Copy link
Member Author

Ping

@burner
Copy link
Member

burner commented Aug 24, 2016

Auto-merge toggled on

@burner burner merged commit f6167ab into dlang:master Aug 24, 2016
@JackStouffer JackStouffer deleted the conv branch August 24, 2016 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants