Make phobos.lib include std.experimental.logger #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what was the problem? from the diff it looked like you just moved the lines! update: |
burner
added a commit
that referenced
this pull request
Feb 24, 2015
Make phobos.lib include std.experimental.logger
|
did not work for win64 fix: #3024 |
|
@MartinNowak somehow the logger was not included in the win32 and win64 build. |
So what was fixed here? |
|
all logger source where not include in phobos.lib and the unittest this fixes it for win32 |
burner
added a commit
that referenced
this pull request
Feb 27, 2015
Make phobos.lib include std.experimental.logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is NOT tested on Win64 because I have no such environment.