Rename std.string.splitterLines to std.string.lineSplitter

[schuetzm]

As discussed in PR #2987.

[schuetzm]

Actually I'd prefer to call it byLine in analogy with std.stdio.byLine, but I'm worried about the small difference in behaviour with respect to line endings (thanks to @ntrel for pointing it out).

[ntrel]

LGTM

[quickfur]

LGTM

[quickfur]

ping @andralex @AndrejMitrovic

[ghost]

Sorry but there's some issue with the autotester.

Sorry, it looks like you don't have permission to this project at github.

[quickfur]

Brad needs to approve him before his PRs will get auto-tested.

[ghost]

No, I have the same problem with Kenji's pull. :/

[quickfur]

Oh? Is something wrong with the auto-tester? I did notice this past week that auto-merged PRs get credited to Brad no matter who toggled it. Wonder if that's related...

[burner]

LGTM

[burner]

Auto-merge toggled on

[kuettler]

Call me old-fashioned. (And I know I am late to the party.) This is a very recent addition and I think it rather rude to rename a library function without consent of its author, especially if the author is @WalterBright. Am I really so far off?

[schuetzm]

Well, there seemed to have been consensus, and Walter didn't speak up in a week so far (neither here nor in his PR). I guess he's ok with it. The important thing IMO is to get a decision before the release, which is due soon.

[tom-tan]

Was splitterLines completely deleted?
IMHO it will be better to leave splitterLines with deprecated attribute to show the migration path to the users.

[ntrel]

@tom-tan splitterLines was never released, so it's OK to rename it.

[ntrel]

Actually it does appear in the release branch here - we need to get this pull merged into 2.067.

[burner]

@MartinNowak "we need to get this pull merged into 2.067."

[tom-tan]

splitterLines was never released, so it's OK to rename it.

I see. I did not notice that.