-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename std.string.splitterLines to std.string.lineSplitter #3018
Conversation
Actually I'd prefer to call it |
LGTM |
1 similar comment
LGTM |
ping @andralex @AndrejMitrovic |
Sorry but there's some issue with the autotester.
|
Brad needs to approve him before his PRs will get auto-tested. |
No, I have the same problem with Kenji's pull. :/ |
Oh? Is something wrong with the auto-tester? I did notice this past week that auto-merged PRs get credited to Brad no matter who toggled it. Wonder if that's related... |
LGTM |
Auto-merge toggled on |
Rename std.string.splitterLines to std.string.lineSplitter
Call me old-fashioned. (And I know I am late to the party.) This is a very recent addition and I think it rather rude to rename a library function without consent of its author, especially if the author is @WalterBright. Am I really so far off? |
Well, there seemed to have been consensus, and Walter didn't speak up in a week so far (neither here nor in his PR). I guess he's ok with it. The important thing IMO is to get a decision before the release, which is due soon. |
Was |
@tom-tan splitterLines was never released, so it's OK to rename it. |
Actually it does appear in the release branch here - we need to get this pull merged into 2.067. |
@MartinNowak "we need to get this pull merged into 2.067." |
I see. I did not notice that. |
Rename std.string.splitterLines to std.string.lineSplitter
As discussed in PR #2987.