-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add very high level description to std.format #3015
Conversation
|
||
$(BOOKTABLE , | ||
$(TR $(TD $(D $(LREF _format))) | ||
$(TD Returns a newly allocated string with the formatting result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth changing this to "GC-allocated" from "newly allocated" for the sake of clarity.
902bfdb
to
b29ae11
Compare
✅ |
Thanks. |
Two functions have been added for convenience: | ||
|
||
$(BOOKTABLE , | ||
$(TR $(TD $(D $(LREF _format))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format
and sformat
are in std.string, so use XREF
, not LREF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, format
and sformat
are publicly imported in std.string. I guess both functions moved to std.format at some point in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, nevermind!
LGTM |
Auto-merge toggled on |
Be more precise about allocation Sort function table
b29ae11
to
7ded904
Compare
So I pushed a comment change to trigger the autotester again. It failed in std.file on Windows, certainly unrelated to this. |
Add very high level description to std.format
Thanks a lot! :) There is also #2997 that goes along the same lines for string. (Just an improvement, honestly.) |
No description provided.