Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very high level description to std.format #3015

Merged
merged 1 commit into from
Feb 21, 2015

Conversation

kuettler
Copy link
Contributor

No description provided.

@kuettler kuettler changed the title Add very high level description for first time readers Add very high level description to std.format for first time readers Feb 20, 2015
@kuettler kuettler changed the title Add very high level description to std.format for first time readers Add very high level description to std.format Feb 20, 2015

$(BOOKTABLE ,
$(TR $(TD $(D $(LREF _format)))
$(TD Returns a newly allocated string with the formatting result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth changing this to "GC-allocated" from "newly allocated" for the sake of clarity.

@Hackerpilot
Copy link
Member

@kuettler
Copy link
Contributor Author

Thanks.

Two functions have been added for convenience:

$(BOOKTABLE ,
$(TR $(TD $(D $(LREF _format)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format and sformat are in std.string, so use XREF, not LREF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, format and sformat are publicly imported in std.string. I guess both functions moved to std.format at some point in time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, nevermind!

@JakobOvrum
Copy link
Member

LGTM

@JakobOvrum
Copy link
Member

Auto-merge toggled on

Be more precise about allocation

Sort function table
@kuettler
Copy link
Contributor Author

So I pushed a comment change to trigger the autotester again. It failed in std.file on Windows, certainly unrelated to this.

braddr added a commit that referenced this pull request Feb 21, 2015
Add very high level description to std.format
@braddr braddr merged commit d7233b7 into dlang:master Feb 21, 2015
@kuettler
Copy link
Contributor Author

Thanks a lot! :) There is also #2997 that goes along the same lines for string. (Just an improvement, honestly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants