Add very high level description to std.format #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuettler
changed the title
kuettler
changed the title
|
|
||
| $(BOOKTABLE , | ||
| $(TR $(TD $(D $(LREF _format))) | ||
| $(TD Returns a newly allocated string with the formatting result. |
There was a problem hiding this comment.
It may be worth changing this to "GC-allocated" from "newly allocated" for the sake of clarity.
kuettler
force-pushed
the
add_format_toc
branch
from
902bfdb to
b29ae11
Compare
|
✅ |
|
Thanks. |
| Two functions have been added for convenience: | ||
|
|
||
| $(BOOKTABLE , | ||
| $(TR $(TD $(D $(LREF _format))) |
There was a problem hiding this comment.
format and sformat are in std.string, so use XREF, not LREF
There was a problem hiding this comment.
Actually, format and sformat are publicly imported in std.string. I guess both functions moved to std.format at some point in time.
|
LGTM |
|
Auto-merge toggled on |
Be more precise about allocation Sort function table
kuettler
force-pushed
the
add_format_toc
branch
from
b29ae11 to
7ded904
Compare
|
So I pushed a comment change to trigger the autotester again. It failed in std.file on Windows, certainly unrelated to this. |
braddr
added a commit
that referenced
this pull request
Feb 21, 2015
Add very high level description to std.format
|
Thanks a lot! :) There is also #2997 that goes along the same lines for string. (Just an improvement, honestly.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.