Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple table for functions to the functional module #3008

Merged
merged 1 commit into from
Feb 20, 2015

Conversation

kuettler
Copy link
Contributor

No description provided.

$(TD Converts a callable to a delegate.
))
$(TR $(TD $(D $(LREF forward)))
$(TD Forwards function arguments with saving ref-ness.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "while" instead of "with"

@quickfur
Copy link
Member

Should the list be sorted, for easier human searching?

@quickfur
Copy link
Member

Other than that, it's looking good. This is a much-needed doc improvement. Thanks!!

@kuettler
Copy link
Contributor Author

Yes, I refrained from sorting since there are groups of functions, but it really makes a difference. You are right.

@quickfur
Copy link
Member

If there are groups of functions, probably we should group them by category, and sort them within each group? E.g., like the old std.algorithm docs here: http://dlang.org/phobos/std_algorithm.html

@kuettler
Copy link
Contributor Author

Nah, too much grouping. This is a small module with a short list of functions, some of which are closely related. Like lessThan and greaterThan. I am aiming for a welcoming summery that gives the curios visitor a first impression. Putting lessThan and greaterThan on the same line matches everyone's thinking (at least I hope so). This is not auto-generated and it is not meant to pretend to be.

@quickfur
Copy link
Member

Fair enough. Let's merge, we can improve on this later if necessary.

@quickfur
Copy link
Member

Auto-merge toggled on

braddr added a commit that referenced this pull request Feb 20, 2015
Add a simple table for functions to the functional module
@braddr braddr merged commit 94d1590 into dlang:master Feb 20, 2015
@kuettler
Copy link
Contributor Author

Thank you. :)

@kuettler kuettler deleted the add_functional_toc branch February 20, 2015 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants