Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the long-deprecated and undocumented std.perf. #1170

Merged
merged 1 commit into from
Feb 26, 2013

Conversation

jmdavis
Copy link
Member

@jmdavis jmdavis commented Feb 25, 2013

No description provided.

@jmdavis
Copy link
Member Author

jmdavis commented Feb 25, 2013

Not sure why this failed on Win64. The error makes no sense to me, and I'm not set up to be able to test Win64. Hopefully, it'll pass on the next round.

@jmdavis
Copy link
Member Author

jmdavis commented Feb 25, 2013

Okay. I think that I figured out the problem with win64.mak. Hopefully, it works this time.

@alexrp
Copy link
Member

alexrp commented Feb 26, 2013

Hm, still failing Win64... but it seems unrelated?

@jmdavis
Copy link
Member Author

jmdavis commented Feb 26, 2013

It seems completely unrelated. Nothing uses std.perf, and no other code should be affected. But the failure isn't happening on the latest master, so I really don't know what the deal is.

@alexrp
Copy link
Member

alexrp commented Feb 26, 2013

Well, I guess I'll merge this.

alexrp added a commit that referenced this pull request Feb 26, 2013
Remove the long-deprecated and undocumented std.perf.
@alexrp alexrp merged commit 684c43d into dlang:master Feb 26, 2013
@jmdavis
Copy link
Member Author

jmdavis commented Feb 26, 2013

It looks like this did indeed break the Win64 build, though I suspect that it's really triggering a compiler bug as opposed to there truly being anything wrong with this commit, as the error is a test failure std.container which should have zero relation to std.perf.

jmdavis added a commit that referenced this pull request Feb 26, 2013
This reverts commit 684c43d, reversing
changes made to 707a601.
@jmdavis
Copy link
Member Author

jmdavis commented Feb 26, 2013

Okay. I just reverted it. I really have no idea what to do about this other than try it again later, as the error seems to be completed unrelated to these changes, and I don't currently have Win64 setup to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants