Skip to content

std.process: Retry interrupted syscalls when creating processes #10885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+14 −3
Merged

std.process: Retry interrupted syscalls when creating processes #10885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions std/process.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,8 +1247,19 @@ private Pid spawnProcessPosix(scope const(char[])[] args,
else
{
closePipeWriteEnds();

T retryInterrupted(T)(scope T delegate() syscall)
{
import core.stdc.errno : errno, EINTR;
T result;
do
result = syscall();
while (result == -1 && .errno == EINTR);
return result;
}

auto status = InternalError.noerror;
auto readExecResult = core.sys.posix.unistd.read(forkPipe[0], &status, status.sizeof);
auto readExecResult = retryInterrupted(() => core.sys.posix.unistd.read(forkPipe[0], &status, status.sizeof));
// Save error number just in case if subsequent "waitpid" fails and overrides errno
immutable lastError = .errno;

Expand All @@ -1257,7 +1268,7 @@ private Pid spawnProcessPosix(scope const(char[])[] args,
// Forked child exits right after creating second fork. So it should be safe to wait here.
import core.sys.posix.sys.wait : waitpid;
int waitResult;
waitpid(id, &waitResult, 0);
retryInterrupted(() => waitpid(id, &waitResult, 0));
}

if (readExecResult == -1)
Expand All @@ -1267,7 +1278,7 @@ private Pid spawnProcessPosix(scope const(char[])[] args,
if (status != InternalError.noerror)
{
int error;
readExecResult = read(forkPipe[0], &error, error.sizeof);
readExecResult = retryInterrupted(() => read(forkPipe[0], &error, error.sizeof));
string errorMsg;
final switch (status)
{
Expand Down
Loading