Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self assignment for dlang/dmd#20696 #10620

Closed
wants to merge 1 commit into from

Conversation

thewilsonator
Copy link
Contributor

No description provided.

@thewilsonator thewilsonator added the Review:Trivial typos, formatting, comments label Jan 13, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10620"

@thewilsonator thewilsonator changed the title Fix self assignment for https://github.com/dlang/dmd/pull/20696 Fix self assignment for dlang/dmd#20696 Jan 13, 2025
@thewilsonator
Copy link
Contributor Author

CI fails because I made this from dlang/ instead of my fork, but is otherwise ready to merge

@thewilsonator thewilsonator deleted the thewilsonator-patch-1 branch January 13, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review:Trivial typos, formatting, comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants